[8.41] Trader & Monopoly (ABUSABLE)

[Vomitus]

I didn't find this in other topics, so here you are.

It appeared in the version when a monopoly was added.

It is ABUSABLE bug.

Scenario:
(a. you have a trader and enough lumber;
b. you have 0-1 points in trading skill(I don't know does it works with 0);
c. you haven't traded for at least 2 mins)
{
1. Go to the trading post and buy an item. Press 'A' button several times(7).
A message '1st trade' appears and waiting time - for next clicks.
2. Go to another trading post - do the same.
3. Return to prev trading post, wait 10 seconds(to be sure that 40 seconds have passed) and trade.
'Monopoly' message appears. And actually monopoly it is.
}

In 8.41 version I cannot exactly reproduce this bug by given scenario, but there is whole chaotic situation with messages that appear when you trade. As I've noticed, most of problems come when you try to trade several times very fast(I usually click RMB + 'A' to catch exact moment when 40 secs ran out).
1. Sometimes 'Monopoly' message appears(not in a moment that it should) and no monopoly actually activated.
2. Once I've lost Monopoly for 40 seconds. Within this time I just went to CP, heal, went to TM, sold all, returned to TP(trade post) and clicked trade - a message '1st trade' appeared. And Monopoly was gone. This situation is quite usual and is easy to reproduce.
3. In 8.41 when trying to reproduce abusable scenario often message '4th trade' appears after '1st trade' then '2nd trade', then again '1st trade'. Somewhere in this order they appeared.

I don't remember what was more but I completely lose control over monopoly situation.

But actually I never lost monopoly when I traded between two TPs uninterrupted by some other actions.

[Bob666]

hmm seems confusing^^ we should better check this

[Exodus]

Like written in the changelog I fixed some things regarding the Monopoly, but I'm not sure if this covers everything you mentioned here, so please recheck this issue.

[Vomitus]

Ok, I will when it will be possible and make you know.

_Edit:

I played several times with a trader and it seems much of bugs were fixed.
As is:
* fixed number of trades required for monopoly(if it says 2, than after 2nd trade you have monopoly, so you have to wait only 1 time);
* fixed most random trade numbers appearing;
* Trade Post control time became more stable.

But there seems to be some more bugs.
Once I lost monopoly on one of the trade posts. something like this:
1. traded on post A(w/ monopoly).
2. traded on post B(w/ monopoly).
3. came to TM to sell items.
4. returned to post B and traded.
Instead of monopoly I got 1st trade.
5. came to post A and traded.
Monopoly here remained.

I believe that variables on different trade posts somehow influence each other. But, of course, I don't know how and it's only mu suggestion.