Multi-Kill Bug

[horselance]

There is a multi kill bug that i first time encountered in ver. 8.27 and then 8.28.
Some enemy has killed someone and he made a triple kill instantly.
Saw same in 8.28 as double kill with only one kill.

Check it please...

[TKF]

This is an old bug, but we don't know what causes it yet. It's usually happens when someone leaves and the trigger that checks for rapid kills that for some reasons makes the doublekill happen at once.

Some enemy has killed someone and he made a triple kill instantly.

I never experienced or seen this one before, unless he made a triplekill after the bugged doublekill.

[horselance]

Strange thing is that i played this map over several thousand times and encountered this bug in 2 maps afterwards for the first time (and second time).
Lets check conditions, this trigger works like this i think: when a player kills someone then a multikill variable gets +1 and starts a one shot timer aprxm. with 4 seconds limit. And if guy kills another enemy within timer, then multikill variable gets +1 and timer restarts and guy get extra bounty etc. if timer ends then variable reseted to 0.
There is nothing about a player related thing that a "player-leave" can cause.
I dont think a player leave event can cause some other guys timer to pause.

[Exodus]

Thats true, I've experienced this bug without leavers, too. The problem is, that this bug appeared in a version where we didn't change anything on the trigger where the multikills are implemented. So this is rather difficult, additionally to the fact that this only happens sometimes, there have to be some special circumstances which we have to find out to fix this bug.

[TKF]

A global integer variable that gets 1, when it's supposed to be 0? Is the same integer variable used in 2 different spots, or does this multikill feature purely use local variable, which in any case should not cause this bug.

[horselance]

Logically it mustn't be global variable.
To find the bug you should check spelling in that trigger. There are always some missing things from our eyes.
Which version was it imported in?

[TKF]

The problem is, that this bug appeared in a version where we didn't change anything on the trigger where the multikills are implemented.

Problem is that the trigger has not been edited when this bugs began to appear. But which version was it? But...

I even experienced a triple kill event only with 2 kills in a row, due the double kill bug. I think this bugs appeared after 8.15. I never experienced this in 8.15 (I think).

My vague theory:
(without knowledge in JASS)
I don't know how the double kill system works, but apparently it's sort of timer controlled. Maybe there's something which makes this stuck after a kill, it's supposed to go 5 sec, but for some reason it get stucked due to a mistake in codes, and then suddenly after 2 min you kill again... suddenly DOUBLE KILL (+200)

This is what I said in the "Bugreport 8.2x", which now is closed. Perhaps you didn't do anything about the multikill trigger in 8.15, but the 8.14 was quickly replaced with 8.15 cuz of the major exploder bug. Any chances that this bug is related to the changes made in 8.20? Or sideeffect by the changes from 8.15 to 8.20? Or later? 8.15?

As I said, I'm not sure when the bug actually did appear. I don't remember with 100% certainty that did did occur in 8.20. Perhaps Exodus know exactly which version it was this occurred, or was first reported at.

[Bob666]

its scripted the way that everytime the value increases by one it checks after 5 seconds if its still the same value, and if it is, then resets it to 0... otherwise the next will do it, because you wont be changing the value all the time...

and i dont know where the bug is either...

perhaps the orders of resetting the value arent correct, because PolledWait() isnt accurate... or any other unit dies and fires the trigger, but crashes after the value is increased...

if the variable is used somewhere else can be checked if you just remove the variable, delete the death trigger and let the game save with another name, it will give an error if its used somewhere else...